| Summary: | ServiceWorkerRegistration update should fail if called from an installing service worker context | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2022-05-02 07:50:45 PDT
Created attachment 458679 [details]
Patch
Comment on attachment 458679 [details]
Patch
win failures unrelated
Comment on attachment 458679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458679&action=review > Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:158 > + if (auto* serviceWorkerGbalScope = dynamicDowncast<ServiceWorkerGlobalScope>(scriptExecutionContext()); serviceWorkerGbalScope && serviceWorkerGbalScope->serviceWorker().state() == ServiceWorkerState::Installing) { typo: serviceWorkerGbalScope Created attachment 458720 [details]
Patch for landing
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Created attachment 458723 [details]
Patch for landing
Committed r293719 (250208@main): <https://commits.webkit.org/250208@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458723 [details]. |