Bug 239914

Summary: The isYahooMail quirk is specific to PLATFORM(IOS_FAMILY)
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, simon.fraser, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Don Olmstead 2022-04-29 15:16:17 PDT 
Found because of an unused function warning for isYahooMail.
Comment 1 Don Olmstead 2022-04-29 15:22:34 PDT 
Created attachment 458612 [details]
Patch
Comment 2 EWS 2022-04-29 20:38:29 PDT 
Committed r293641 (250145@main): <https://commits.webkit.org/250145@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458612 [details].
Comment 3 Radar WebKit Bug Importer 2022-04-29 20:39:14 PDT 
<rdar://problem/92556090>
Comment 4 Darin Adler 2022-04-30 13:55:21 PDT 
Comment on attachment 458612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458612&action=review

> Source/WebCore/ChangeLog:10
> +        The isYahooMail check is incorrectly guarded by ENABLE(PUBLIC_SUFFIX_LIST) when the only
> +        using this function is guarded by ENABLE(IOS_TOUCH_EVENTS) and PLATFORM(IOS_FAMILY). Use
> +        PLATFORM(IOS_FAMILY) since ENABLE(IOS_TOUCH_EVENTS) implies that anyways.

I suppose this is a losing battle at this point, but I’ve tried to always use something more specific than the PLATFORM macro whenever possible. So in this case I would have used ENABLE(IOS_TOUCH_EVENTS).