Bug 239913

Summary:

[CMake] Add a macro to set source file language

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, stephan.szabo, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=239873

Attachments:

Description	Flags
WIP Patch	none

Description Don Olmstead 2022-04-29 14:25:27 PDT

After the change in r239873 the Visual Studio build for PlayStation fails due to the unified c file being compiled with -std=c++. Specify the language type to get around this.

Comment 1 Don Olmstead 2022-04-29 15:06:03 PDT

Created attachment 458611 [details]
WIP Patch

Comment 2 Stephan Szabo 2022-04-29 15:24:52 PDT

I'm not sure how you will want to handle https://github.com/WebKit/WebKit/blob/main/Source/bmalloc/CMakeLists.txt#L685-L696 with this. It happens after the WEBKIT_FRAMEWORK* in the file, so if I'm reading this right we'll set the standard to a C language standard but then later change the compile language to C++.