Bug 239877

Summary: [LBSE] ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOS
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233211
Bug Depends on:    
Bug Blocks: 90738    
Attachments:
Description Flags
Patch, v1
none
Patch, v2
simon.fraser: review+, zimmermann: commit-queue+
[fast-cq] Patch, v3 (removed ChangeLogs for landing) none

Description Simon Fraser (smfr) 2022-04-28 17:05:58 PDT 
https://trac.webkit.org/changeset/286204/webkit added:

#if !defined(ENABLE_LAYER_BASED_SVG_ENGINE) && PLATFORM(MAC)
#define ENABLE_LAYER_BASED_SVG_ENGINE 1
#endif

We don't want the value of ENABLE_LAYER_BASED_SVG_ENGINE to differ between macOS and iOS. For testing and performance consistency, it has to be the same for all Cocoa platforms.
Comment 1 Nikolas Zimmermann 2022-05-05 13:32:22 PDT 
I was not aware of that. Shall I prepare a fix?
Comment 2 Simon Fraser (smfr) 2022-05-05 14:24:28 PDT 
Please do.
Comment 3 Radar WebKit Bug Importer 2022-05-05 17:06:13 PDT 
<rdar://problem/92829309>
Comment 4 Nikolas Zimmermann 2022-05-06 01:26:15 PDT 
Created attachment 458939 [details]
Patch, v1
Comment 5 Nikolas Zimmermann 2022-05-16 04:25:31 PDT 
Created attachment 459414 [details]
Patch, v2
Comment 6 Nikolas Zimmermann 2022-05-18 01:31:18 PDT 
Comment on attachment 459414 [details]
Patch, v2

Let's see if cq can process this even with the ChangeLog changes...
Comment 7 Nikolas Zimmermann 2022-05-18 04:16:00 PDT 
Created attachment 459535 [details]
[fast-cq] Patch, v3 (removed ChangeLogs for landing)
Comment 8 EWS 2022-05-18 04:24:23 PDT 
Committed r294389 (250684@main): <https://commits.webkit.org/250684@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459535 [details].