| Summary: | Web Inspector: Regression(r267038) Import a timeline does not render the timeline, only lists the events | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Angle <pangle> | ||||||
| Component: | Web Inspector | Assignee: | Patrick Angle <pangle> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick Angle
2022-04-28 14:30:01 PDT
Created attachment 458560 [details]
Patch v1.0
Comment on attachment 458560 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=458560&action=review r=me, nice fix =D > Source/WebInspectorUI/ChangeLog:18 > + The second issue is that when importing a timeline, we should ignore the current capturing state when setting > + the current, start, and end times, otherwise not all the values will be commited since most likely no recording > + is in progress at the same time a recording is being imported. Along these lines, i feel like we should always ignore the current capturing state. We don't want an imported recording to suddenly start showing new data because we started another recording. > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:127 > + this._updateTimes(startTime, endTime, endTime, {fromImport: true}); NIT: do we actually need a parameter, or can we just use `this._recording.imported` instead at each usage? Created attachment 458606 [details]
Patch v1.1
Committed r293631 (250137@main): <https://commits.webkit.org/250137@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458606 [details]. |