| Summary: | Register shared workers as service worker clients | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2022-04-28 05:17:08 PDT
Created attachment 458518 [details]
Patch
Created attachment 458522 [details]
Patch
Comment on attachment 458522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458522&action=review > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:52 > + WEBCORE_EXPORT static bool isEmpty(); This function name is super confusing. What does it mean for a SharedWorkerProxy to be empty? I'd suggest something like hasInstances() but I'd be open to suggestions. I don't think we should land "isEmpty()" though. (In reply to Chris Dumez from comment #3) > Comment on attachment 458522 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458522&action=review > > > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:52 > > + WEBCORE_EXPORT static bool isEmpty(); > > This function name is super confusing. What does it mean for a > SharedWorkerProxy to be empty? > I'd suggest something like hasInstances() but I'd be open to suggestions. I > don't think we should land "isEmpty()" though. Agreed hasInstances is better Created attachment 458678 [details]
Patch
Committed r293665 (250169@main): <https://commits.webkit.org/250169@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458678 [details]. |