| Summary: | [GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref' | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||
| Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, bugs-noreply, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer, zdobersek | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=239482 https://bugs.webkit.org/show_bug.cgi?id=239881 |
||||||
| Attachments: |
|
||||||
|
Description
Diego Pino
2022-04-27 00:20:05 PDT
Created attachment 458424 [details]
Patch
Because of this bug Ubuntu 20.04 build bot is failing: https://build.webkit.org/#/builders/30/builds/442/steps/9/logs/stdio Committed r293505 (250036@main): <https://commits.webkit.org/250036@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458424 [details]. Comment on attachment 458424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458424&action=review > Source/WTF/wtf/StdLibExtras.h:608 > +// TODO: Needed for GCC<=9.3. Remove it after Ubuntu 20.04 end of support (May 2023). Please use FIXME, not TODO: https://webkit.org/code-style-guidelines/ This patch broke Debian 10 build bot since __cplusplus value is 201709L for GCC8.3. https://build.webkit.org/#/builders/46/builds/13047/steps/8/logs/stdio Follow-up in https://bugs.webkit.org/show_bug.cgi?id=239881 |