Bug 239792

Summary:

Drop StringImpl::createFromLiteral()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Template Framework

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Hironori.Fujii, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for landing	none

Description Chris Dumez 2022-04-26 15:40:59 PDT

Drop StringImpl::createFromLiteral().

Call sites that have an ASCIILiteral can now simply call StringImpl::create(ASCIILiteral). Call sites that have raw characters can call the existing StringImpl::createWithoutCopying().

This simplifies our API a bit.

Comment 1 Chris Dumez 2022-04-26 16:01:52 PDT

Pull request: https://github.com/WebKit/WebKit/pull/405

Comment 2 EWS 2022-04-29 10:48:33 PDT

Committed r293621 (250127@main): <https://commits.webkit.org/250127@main>

Reviewed commits have been landed. Closing PR #405 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-04-29 10:49:13 PDT

<rdar://problem/92532725>

Comment 4 Chris Dumez 2022-04-29 17:52:22 PDT

Reopening since it was temporary reverted to address some internal EWS issues.

Comment 5 Chris Dumez 2022-05-03 19:54:33 PDT

Pull request: https://github.com/WebKit/WebKit/pull/490

Comment 6 EWS 2022-05-04 00:03:46 PDT

Committed r293763 (250242@main): <https://commits.webkit.org/250242@main>

Reviewed commits have been landed. Closing PR #490 and removing active labels.

Comment 7 Fujii Hironori 2022-05-05 23:12:54 PDT

Reopening to attach new patch.

Comment 8 Fujii Hironori 2022-05-05 23:12:57 PDT

Created attachment 458934 [details]
Patch for landing

Comment 9 EWS 2022-05-06 00:27:19 PDT

Committed r293882 (250340@main): <https://commits.webkit.org/250340@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458934 [details].

Comment 10 Chris Dumez 2022-05-06 07:02:46 PDT

(In reply to Fujii Hironori from comment #7)
> Reopening to attach new patch.

Thank you for fixing!