Bug 239782

Summary:

REGRESSION (r293117): Context menu lift animation encompasses the entire web view

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Platform

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-

Description Wenson Hsieh 2022-04-26 12:06:03 PDT

rdar://92342919

Comment 1 Wenson Hsieh 2022-04-26 12:08:42 PDT

Created attachment 458387 [details]
Patch

Comment 2 Aditya Keerthi 2022-04-26 12:19:40 PDT

Comment on attachment 458387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458387&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-11898
> -- (UITargetedPreview *)contextMenuInteraction:(UIContextMenuInteraction *)interaction configuration:(UIContextMenuConfiguration *)configuration previewForHighlightingItemWithIdentifier:(id<NSCopying>)identifier

The bug is probably due to using `previewForHighlightingItemWithIdentifier` rather than `highlightPreviewForItemWithIdentifier` here.

But fine to revert if we need an immediate fix.

Comment 3 Wenson Hsieh 2022-04-26 12:20:45 PDT

(In reply to Aditya Keerthi from comment #2)
> Comment on attachment 458387 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458387&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-11898
> > -- (UITargetedPreview *)contextMenuInteraction:(UIContextMenuInteraction *)interaction configuration:(UIContextMenuConfiguration *)configuration previewForHighlightingItemWithIdentifier:(id<NSCopying>)identifier
> 
> The bug is probably due to using `previewForHighlightingItemWithIdentifier`
> rather than `highlightPreviewForItemWithIdentifier` here.
> 
> But fine to revert if we need an immediate fix.

Yep! I'm checking to make sure that just moving to `-highlightPreviewForItemWithIdentifier` fixes this. If so, I'll land a version of the patch that just adopts the new method.

Comment 4 Wenson Hsieh 2022-04-26 12:40:45 PDT

Created attachment 458388 [details]
Patch

Comment 5 EWS 2022-04-26 14:19:15 PDT

Tools/Scripts/svn-apply failed to apply attachment 458388 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Comment 6 Wenson Hsieh 2022-04-26 14:25:40 PDT

Committed r293448: <https://commits.webkit.org/r293448>