Bug 239771

Summary:	Block all direct pushes to GitHub
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	jbedard, mcatanzaro, webkit-bug-importer, ysuzuki
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Michael Catanzaro 2022-04-26 08:19:45 PDT

Today I accidentally pushed a sidebranch the main repo instead of my personal fork. We should block this from happening since we want people to create pull requests only from forks.

Comment 1 Yusuke Suzuki 2022-04-26 10:36:16 PDT

It is good if we can avoid creating a branch in the upstream repository.

Comment 2 Michael Catanzaro 2022-04-26 12:17:41 PDT

Caveat: we probably do want to allow pushing to stable branches (including creating new branches) webkit-* and safari-*-branch.

Comment 3 Radar WebKit Bug Importer 2022-05-03 08:20:20 PDT

<rdar://problem/92669177>

Comment 4 Jonathan Bedard 2022-06-13 09:58:15 PDT

I've prevented pushes to:
eng/*
dev/*
bug/*

Additionally, we have branch protections on:
main
safari-*-branch

Happy to add more, but I also don't want to hamper folks ability to use feature branches, if we feel that is useful.