| Summary: | Ensure completion handler is called in SWServer::clear | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||
| Component: | Service Workers | Assignee: | Sihui Liu <sihui_liu> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sihui Liu
2022-04-25 21:39:38 PDT
Created attachment 458325 [details]
Patch
Comment on attachment 458325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458325&action=review > Source/WebCore/workers/service/server/SWServer.cpp:348 > + if (m_registrationStore) { I would reverse the check, something like: if (! m_registrationStore) { completionHandler(); return; } Comment on attachment 458325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458325&action=review >> Source/WebCore/workers/service/server/SWServer.cpp:348 >> + if (m_registrationStore) { > > I would reverse the check, something like: > if (! m_registrationStore) { completionHandler(); return; } Sure, will change. Created attachment 458466 [details]
Patch for landing
Committed r293550 (250070@main): <https://commits.webkit.org/250070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458466 [details]. |