Bug 239705

Summary: Skip microbenchmarks/memcpy-wasm.js and friends on non-FTL (i.e. non-WASM) platforms
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing ews-feeder: commit-queue-

Description Zan Dobersek 2022-04-24 10:34:56 PDT
Skip microbenchmarks/memcpy-wasm.js and friends on non-FTL (i.e. non-WASM) platforms
Comment 1 Zan Dobersek 2022-04-24 10:43:51 PDT
Created attachment 458232 [details]
Patch
Comment 2 EWS 2022-04-24 12:45:17 PDT
/Volumes/Data/worker/Commit-Queue/build/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 3 Yusuke Suzuki 2022-04-24 22:41:52 PDT
Comment on attachment 458232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458232&action=review

> JSTests/ChangeLog:9
> +        Mark microbenchmarks/memcpy-wasm.js and related tests as skipped on
> +        non-FTL platforms since WASM tests are not run there, resulting in
> +        failures when they're executed.
> +

Reviewed by line is not included
Comment 4 Zan Dobersek 2022-04-24 23:23:55 PDT
Created attachment 458245 [details]
Patch for landing

Fixed the dropped Reviewed-by line.
Comment 5 Zan Dobersek 2022-04-24 23:26:47 PDT
Comment on attachment 458245 [details]
Patch for landing

Clearing flags on attachment: 458245

Committed r293312 (249935@trunk): <https://commits.webkit.org/249935@trunk>
Comment 6 Zan Dobersek 2022-04-24 23:26:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2022-04-24 23:27:14 PDT
<rdar://problem/92251177>