| Summary: | Reduce sizeof(CSSNumericType) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2022-04-22 18:03:21 PDT
Created attachment 458191 [details]
Patch
Comment on attachment 458191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458191&action=review > Source/WebCore/css/typedom/numeric/CSSNumericType.h:39 > + using BaseTypeStorage = Markable<int, IntegralMarkableTraits<int, std::numeric_limits<int>::min()>>; We handle INT_MIN as nullopt value, is it correct for these types? If it is ok, then r=me. Comment on attachment 458191 [details]
Patch
In practice most of these values will just be 1 or nullopt, the consequence of hitting INT_MIN are understandable, and the memory wins are worth it in my opinion.
Committed r293278 (249908@main): <https://commits.webkit.org/249908@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458191 [details]. |