Bug 239676

Summary: Web Inspector: response overrides with an error status code should indicate that somewhere
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pangle: review+, ews-feeder: commit-queue-
Patch none

Description Devin Rousso 2022-04-22 16:44:07 PDT 
it's odd that the local override shows as regular "text" when resources loaded from it have error (i.e. red) "text"
Comment 1 Devin Rousso 2022-04-22 16:47:40 PDT 
Created attachment 458187 [details]
Patch
Comment 2 Patrick Angle 2022-04-22 17:03:46 PDT 
Comment on attachment 458187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458187&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js:111
>          // Do nothing. Do not allow ResourceTreeElement / SourceCodeTreeElement to modify our status element.

I think the "Do nothing" part of this is contradicted now 😅. (As an aside, I had to read this comment a few times before I realized it was trying to explain why we don't let `super` be called.)
Comment 3 Devin Rousso 2022-04-25 11:08:08 PDT 
Created attachment 458284 [details]
Patch
Comment 4 EWS 2022-04-25 12:55:21 PDT 
Committed r293338 (249959@main): <https://commits.webkit.org/249959@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458284 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-25 12:56:13 PDT 
<rdar://problem/92288790>