| Summary: | service worker update should refresh imported scripts in addition to the main script | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, mkwst, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=243410 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2022-04-22 09:41:13 PDT
Created attachment 458156 [details]
Patch
Created attachment 458260 [details]
Patch
Created attachment 458263 [details]
Patch
Comment on attachment 458263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458263&action=review r=me > Source/WebCore/workers/service/server/SWServer.cpp:567 > + m_scripts.append(std::make_pair(url, WTFMove(result.script))); Can probably just: m_scripts.append({ url, WTFMove(result.script) }); > Source/WebCore/workers/service/server/SWServerJobQueue.cpp:114 > + RELEASE_LOG(ServiceWorker, "%p - SWServerJobQueue::scriptFetchFinished, script, certificate and imported scripts are matching for registrationID=%llu", this, registration->identifier().toUInt64()); %llu -> PRIu64 > Source/WebCore/workers/service/server/SWServerJobQueue.cpp:135 > + RELEASE_LOG(ServiceWorker, "%p - SWServerJobQueue::importedScriptsFetchFinished, script, certificate and imported scripts are matching for registrationID=%llu", this, registration->identifier().toUInt64()); PRIu64 Created attachment 458426 [details]
Patch
Committed r293506 (250037@main): <https://commits.webkit.org/250037@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458426 [details]. |