| Summary: | [LFC][Integration] Add FlexFormattingContextIntegrationEnabled setting | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, sam, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-04-22 07:45:03 PDT
Created attachment 458148 [details]
Patch
Comment on attachment 458148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458148&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:310 > + webcoreBinding: RuntimeEnabledFeatures I know the existing LFC flags are RuntimeEnabledFeatures but I wonder if this needs to be. I think they are disfavoured for some reason. Created attachment 458153 [details]
Patch
(In reply to Antti Koivisto from comment #2) > Comment on attachment 458148 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458148&action=review > > > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:310 > > + webcoreBinding: RuntimeEnabledFeatures > > I know the existing LFC flags are RuntimeEnabledFeatures but I wonder if > this needs to be. I think they are disfavoured for some reason. Because RuntimeEnabledFeatures are per web process but the UI makes it look like it behaves like a per-Page thing, so stuff breaks when there is > 1 Page per process. Committed r293233 (249897@main): <https://commits.webkit.org/249897@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458153 [details]. |