| Summary: | Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||
| Component: | Tools / Tests | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, gsnedders, jbedard, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=243447 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kimmo Kinnunen
2022-04-22 02:55:33 PDT
Created attachment 458127 [details]
Patch
Created attachment 458334 [details]
Patch
Committed r293498 (250031@main): <https://commits.webkit.org/250031@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458334 [details]. Comment on attachment 458334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review > Tools/Scripts/VCSUtils.pm:-856 > - # The first and second paths can differ in the case of copies > - # and renames. We use the second file path because it is the > - # destination path. Just noticed this comment. Was there a reason to remove it? Comment on attachment 458334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review >> Tools/Scripts/VCSUtils.pm:-856 >> - # destination path. > > Just noticed this comment. Was there a reason to remove it? It's a stale comment from the era when the logic of parseGitDiffStartLine was inline in this function, and the regex extracted both the first path and second path from the match. There's no "first path" nor "second path" in this context anymore. parseGitDiffStartLine documents that it returns the destination file for each file diff section in a git patch. bug 38628 |