| Summary: | Bail out from text decoration computation if none is requested | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Antti Koivisto <koivisto> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, ntim, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2022-04-22 01:21:15 PDT
Created attachment 458120 [details]
Patch
Comment on attachment 458120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458120&action=review > Source/WebCore/rendering/TextDecorationPainter.cpp:413 > + if (requestedDecorations.isEmpty()) > + return { }; Can we use the same more strict check like above? or does that cause issues? Fwiw, blink isn't supported, and none should do nothing. Created attachment 458134 [details]
Patch for landing
> Can we use the same more strict check like above? or does that cause issues?
> Fwiw, blink isn't supported, and none should do nothing.
Good point, though I went to other directions by just using isEmpty(). I also removed the unused None value.
Committed r293217 (249886@main): <https://commits.webkit.org/249886@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458134 [details]. |