| Summary: | Add WKNotification and WKWebsiteDataStore SPI for handling click/close of persistent notifications | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | cdumez, nham, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Brady Eidson
2022-04-21 20:31:38 PDT
Created attachment 458109 [details]
EWS v1
Created attachment 458170 [details]
Patch
Comment on attachment 458170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458170&action=review > Source/WebCore/Modules/notifications/NotificationDataCocoa.mm:72 > + NotificationData data { title, body, iconURL, tag, language, direction, originString, URL { String { serviceWorkerRegistrationURL } }, *uuid, PAL::SessionID { sessionID.unsignedLongLongValue }, { } }; Return we could just: return { title, body, iconURL, tag, language, direction, originString, URL { String { serviceWorkerRegistrationURL } }, *uuid, PAL::SessionID { sessionID.unsignedLongLongValue }, { } }; > Tools/WebKitTestRunner/cocoa/WebNotificationProviderCocoa.mm:39 > + RetainPtr<NSDictionary> dictionaryRepresentation = adoptNS(WKNotificationCopyDictionaryRepresentation(notification.get())); could use auto. Created attachment 458179 [details]
Patch for landing v1
Created attachment 458182 [details]
PFL v2
Created attachment 458192 [details]
PFL v3
Created attachment 458211 [details]
PFL v4
Created attachment 458220 [details]
THANK YOU FOR THE PAIN UNIFIED BUILD v5
Created attachment 458221 [details]
Never had this much of a problem fighting missing includes in unified build v6
Created attachment 458222 [details]
Maybe found the source of problems v7
Committed r293296 (249921@main): <https://commits.webkit.org/249921@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458222 [details]. |