Bug 239542

Summary: generate-automation-atom.py breaks under older python with non-ascii inputs
Product: WebKit Reporter: Daniel Kolesa <dkolesa>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, cgarcia, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
fix style
none
fixed patch none

Description Daniel Kolesa 2022-04-20 07:36:27 PDT 
File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
  return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 1983: ordinal not in range(128)

for Source/WebKit/UIProcess/Automation/atoms/FindNodes.js

This is because of https://github.com/q66/WebKit/blob/main/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js#L123 (the ยง character)
Comment 1 Daniel Kolesa 2022-04-20 07:38:34 PDT 
Created attachment 457987 [details]
patch
Comment 2 Daniel Kolesa 2022-04-20 07:43:45 PDT 
Created attachment 457989 [details]
fix style
Comment 3 Daniel Kolesa 2022-04-20 07:47:00 PDT 
Created attachment 457990 [details]
fixed patch
Comment 4 Adrian Perez 2022-04-24 14:12:54 PDT 
Comment on attachment 457990 [details]
fixed patch

The failure from the ios-wk2 builder is unrelated, let's land this.
Comment 5 EWS 2022-04-24 14:17:55 PDT 
Committed r293307 (249930@main): <https://commits.webkit.org/249930@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457990 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-24 14:18:14 PDT 
<rdar://problem/92238946>