Bug 239508

Summary: [iOS] Dictation text that contains emojis is inserted twice upon finalization
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 239467    
Bug Blocks:    
Attachments:
Description Flags
Patch
akeerthi: review+
Address comment none

Wenson Hsieh
Reported 2022-04-19 10:38:46 PDT
rdar://91895524
Attachments
Patch (7.04 KB, patch)
2022-04-19 12:06 PDT, Wenson Hsieh 		akeerthi: review+
DetailsFormatted DiffDiff
Address comment (7.03 KB, patch)
2022-04-19 15:02 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-04-19 12:06:33 PDT
Created attachment 457924 [details] Patch
Chris Dumez
Comment 2 2022-04-19 14:28:32 PDT
Comment on attachment 457924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457924&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2406 > + for (size_t i = 0; i < numGraphemeClusters(oldText); ++i) Shouldn't we cache numGraphemeClusters(oldText) before the loop? Or is oldText changing as we iterate?
Wenson Hsieh
Comment 3 2022-04-19 14:29:21 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 457924 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457924&action=review > > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2406 > > + for (size_t i = 0; i < numGraphemeClusters(oldText); ++i) > > Shouldn't we cache numGraphemeClusters(oldText) before the loop? Or is > oldText changing as we iterate? Good catch! `oldText` isn't changing, so we should pull this out into a local variable. I'll fix this before landing.
Wenson Hsieh
Comment 4 2022-04-19 15:02:30 PDT
Created attachment 457938 [details] Address comment
EWS
Comment 5 2022-04-19 17:26:26 PDT
Committed r293051 (249786@main): <https://commits.webkit.org/249786@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457938 [details].
Note You need to log in before you can comment on or make changes to this bug.