| Summary: | REGRESSION(r292863): std::remove_cvref_t not defined in GCC9< | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||
| Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dkolesa, ews-watchlist, webkit-bug-importer, zan, zdobersek | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=238740 https://bugs.webkit.org/show_bug.cgi?id=239805 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
Diego Pino
2022-04-18 23:14:56 PDT
Created attachment 457858 [details]
Patch
should probably make it conditional for `__GLIBCXX__` to avoid affecting libc++ environments (like mac) Created attachment 457907 [details]
Patch
Comment on attachment 457907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457907&action=review > Source/WTF/wtf/StdLibExtras.h:612 > +template <typename T> > +struct remove_cvref { > + using type = typename std::remove_cv<typename std::remove_reference<T>::type>::type; > +}; This has to be in the std namespace too. Created attachment 458032 [details]
Patch
zan@falconsigh.net does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 458032 [details] from commit queue. zan@falconsigh.net does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 458032 [details] from commit queue. Committed r293148 (249844@main): <https://commits.webkit.org/249844@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458032 [details]. |