| Summary: | [WebXR] Update Device::initializeTrackingAndRendering() to take in more parameters regarding the session setup | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||
| Component: | New Bugs | Assignee: | Ada Chan <adachan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, dino, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ada Chan
2022-04-18 17:24:06 PDT
Created attachment 457845 [details]
Patch
Comment on attachment 457845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457845&action=review > Source/WebKit/Shared/XR/XRDeviceProxy.h:32 > +#include <WebCore/SecurityOriginData.h> Seems like this header could just use a forward declaration of WebCore::SecurityOriginData. The .cpp files can include the header. Created attachment 457852 [details]
Patch
(In reply to Darin Adler from comment #2) > Comment on attachment 457845 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457845&action=review > > > Source/WebKit/Shared/XR/XRDeviceProxy.h:32 > > +#include <WebCore/SecurityOriginData.h> > > Seems like this header could just use a forward declaration of > WebCore::SecurityOriginData. The .cpp files can include the header. Yes! Fixed. Thanks for catching that! Committed r293033 (249772@main): <https://commits.webkit.org/249772@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457852 [details]. |