Bug 239434

Summary: AX: Update the isolated tree in response to AXElementBusyChanged and AXTextChanged notifications
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description Tyler Wilcock 2022-04-17 08:53:13 PDT 
Update the isolated tree in response to AXElementBusyChanged and AXTextChanged notifications
Comment 1 Radar WebKit Bug Importer 2022-04-17 08:53:21 PDT 
<rdar://problem/91862868>
Comment 2 Tyler Wilcock 2022-04-17 09:00:03 PDT 
Created attachment 457771 [details]
Patch
Comment 3 chris fleizach 2022-04-17 09:05:18 PDT 
Comment on attachment 457771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457771&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1302
> +void AccessibilityNodeObject::setElementAttributeValue(const QualifiedName& attributeName, bool value)

Do we still use this for anything?
Comment 4 Tyler Wilcock 2022-04-17 09:30:14 PDT 
Created attachment 457772 [details]
Patch
Comment 5 Tyler Wilcock 2022-04-17 09:30:59 PDT 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1302
> > +void AccessibilityNodeObject::setElementAttributeValue(const QualifiedName& attributeName, bool value)
> 
> Do we still use this for anything?
Nope, good point! Removed the function entirely in the latest patch.
Comment 6 Tyler Wilcock 2022-04-17 10:20:01 PDT 
Created attachment 457773 [details]
Patch
Comment 7 Tyler Wilcock 2022-04-17 10:41:59 PDT 
Created attachment 457774 [details]
Patch
Comment 8 Andres Gonzalez 2022-04-18 13:14:37 PDT 
(In reply to Tyler Wilcock from comment #7)
> Created attachment 457774 [details]
> Patch

--- a/Source/WebCore/ChangeLog
+++ a/Source/WebCore/ChangeLog

+        Tests: accessibility/accessibility-text-updates-after-dynamic-change.html

Can we call this just accessibility/text-updates-after-dynamic-change.html?
Comment 9 Tyler Wilcock 2022-04-18 15:23:24 PDT 
Created attachment 457829 [details]
Patch
Comment 10 Tyler Wilcock 2022-04-18 20:20:31 PDT 
> +        Tests:
> accessibility/accessibility-text-updates-after-dynamic-change.html
> 
> Can we call this just accessibility/text-updates-after-dynamic-change.html?
Good idea, fixed this.
Comment 11 EWS 2022-04-18 20:26:23 PDT 
Committed r293006 (249745@main): <https://commits.webkit.org/249745@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457829 [details].