Bug 239411

Summary:	GitHub EWS is confused with prior PR's merge-blocked label
Product:	WebKit	Reporter:	Yusuke Suzuki <ysuzuki>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, cdumez, jbedard, mcatanzaro, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082, 239613

Description Yusuke Suzuki 2022-04-15 16:49:59 PDT

If we update PRs multiple times in a short period,

1. The former EWS run is still running while new PR is uploaded
2. The former EWS puts `merge-blocked` label if it failed, even though a new change is uploaded to this PR
3. If the former EWS puts `merge-blocked` accidentally, it prevents us from running EWS tests in a new PR

So, EWS should put `merge-blocked` label only when PR's latest change matches to the patch of EWS.

Comment 1 Aakash Jain 2022-04-18 09:28:08 PDT

Also, it might make sense to automatically remove 'merge-blocked' label while uploading new version of the PR, using 'git-webkit pr' command.

Comment 2 Michael Catanzaro 2022-04-19 07:56:21 PDT

(In reply to Yusuke Suzuki from comment #0)
> 1. The former EWS run is still running while new PR is uploaded

:/ Ideally a force push would immediately cancel any previous EWS runs.

Comment 3 Yusuke Suzuki 2022-04-21 10:46:12 PDT

Right now, it is hard to run EWS tests on GitHub because of this issue.
Previous EWS runs slowly and puts merge-blocked label at random time,
and which blocks newly scheduled EWS tests.

Comment 4 Jonathan Bedard 2022-04-21 12:04:11 PDT

(In reply to Aakash Jain from comment #1)
> Also, it might make sense to automatically remove 'merge-blocked' label
> while uploading new version of the PR, using 'git-webkit pr' command.

We already do that.

Comment 5 Yusuke Suzuki 2022-04-21 15:54:59 PDT

In https://bugs.webkit.org/show_bug.cgi?id=239613, it seems that we failed to run EWS on GitHub because of this and it was labeled with check-mark.

Comment 6 Radar WebKit Bug Importer 2022-04-22 16:50:14 PDT

<rdar://problem/92196846>

Comment 7 Jonathan Bedard 2022-04-25 11:42:08 PDT

*** Bug 239731 has been marked as a duplicate of this bug. ***

Comment 8 Jonathan Bedard 2022-04-25 13:27:37 PDT

Pull request: https://github.com/WebKit/WebKit/pull/380

Comment 9 EWS 2022-04-25 17:22:26 PDT

Committed r293381 (249971@main): <https://commits.webkit.org/249971@main>

Reviewed commits have been landed. Closing PR #380 and removing active labels.