| Summary: | Use ProcessTerminationReason::Unresponsive for unresponsive network processes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | WebKit2 | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, kkinnunen, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2022-04-15 13:47:01 PDT
Created attachment 457719 [details]
Patch
Comment on attachment 457719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457719&action=review > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:166 > weakThis->terminate(); Seems like it would be less error-prone to have an ProcessTerminationReason = ProcessTerminationReason::RequestedByClient optional parameter on terminate(), rather than relying on the call site to call networkProcessDidTerminate() by itself. (In reply to Chris Dumez from comment #2) > Comment on attachment 457719 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457719&action=review > > > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:166 > > weakThis->terminate(); > > Seems like it would be less error-prone to have an ProcessTerminationReason > = ProcessTerminationReason::RequestedByClient optional parameter on > terminate(), rather than relying on the call site to call > networkProcessDidTerminate() by itself. I considered that, but terminate() is virtual in AuxiliaryProcess so I'd have to change all of them, and the others use the pattern I followed here. Comment on attachment 457719 [details]
Patch
Breaks some tests because terminate() needs to trigger logging.
Created attachment 457815 [details]
Patch
Committed r293017 (249756@main): <https://commits.webkit.org/249756@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457815 [details]. |