Bug 239393

Summary:

Apply purifyNaN in more places.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	saam: review+
patch for landing.	none

Description Mark Lam 2022-04-15 11:09:40 PDT

<rdar://problem/91761362>

Comment 1 Mark Lam 2022-04-15 11:15:58 PDT

Created attachment 457707 [details]
proposed patch.

Comment 2 Saam Barati 2022-04-15 12:03:19 PDT

Comment on attachment 457707 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=457707&action=review

> Source/JavaScriptCore/wasm/WasmInstance.h:137
> +    double loadF64Global(unsigned i) const { return purifyNaN(bitwise_cast<double>(loadI64Global(i))); }

let's just delete this function?

Comment 3 Mark Lam 2022-04-15 12:14:59 PDT

Created attachment 457712 [details]
patch for landing.

Comment 4 Mark Lam 2022-04-15 12:55:33 PDT

Thanks for the review.  Landed in r292920: <http://trac.webkit.org/r292920>.