Bug 239388

Summary: [ Monterey wk2 ] WebGL conformance tests are a flaky time out
Product: WebKit Reporter: Karl Rackler <rackler>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: ben_schwartz, dino, kbr, kkinnunen, pnormand, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 255281    
Bug Blocks: 239640    

Description Karl Rackler 2022-04-15 08:55:11 PDT 
Description:
webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html
webgl/2.0.0/conformance/glsl/misc/struct-nesting-of-variable-names.html
webgl/2.0.0/conformance/textures/canvas/tex-2d-rgb-rgb-unsigned_byte.html
webgl/2.0.0/conformance/textures/canvas/tex-2d-rgb-rgb-unsigned_short_5_6_5.html
webgl/2.0.0/conformance/textures/canvas/tex-2d-rgba-rgba-unsigned_byte.html
webgl/2.0.0/conformance/textures/canvas/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html
webgl/2.0.0/conformance/textures/canvas/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html
webgl/2.0.0/conformance/textures/webgl_canvas/tex-2d-rgb-rgb-unsigned_byte.html
webgl/2.0.0/conformance/textures/webgl_canvas/tex-2d-rgb-rgb-unsigned_short_5_6_5.html
webgl/2.0.0/conformance/uniforms/out-of-bounds-uniform-array-access.html

There was not one commit that I observe causing this issue.  These tests seem to have been flaky since the start.

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Funiforms%2Fout-of-bounds-uniform-array-access.html&test=webgl%2F2.0.0%2Fconformance%2Fglsl%2Fmisc%2Fstruct-nesting-of-variable-names.html&test=webgl%2F2.0.0%2Fconformance%2Ftextures%2Fcanvas%2Ftex-2d-rgb-rgb-unsigned_byte.html&test=webgl%2F2.0.0%2Fconformance%2Ftextures%2Fcanvas%2Ftex-2d-rgb-rgb-unsigned_short_5_6_5.html&test=webgl%2F2.0.0%2Fconformance%2Ftextures%2Fcanvas%2Ftex-2d-rgba-rgba-unsigned_byte.html&test=webgl%2F2.0.0%2Fconformance%2Ftextures%2Fcanvas%2Ftex-2d-rgba-rgba-unsigned_short_4_4_4_4.html&test=webgl%2F2.0.0%2Fconformance%2Ftextures%2Fcanvas%2Ftex-2d-rgba-rgba-unsigned_short_5_5_5_1.html&test=webgl%2F2.0.0%2Fconformance%2Ftextures%2Fwebgl_canvas%2Ftex-2d-rgb-rgb-unsigned_byte.html&test=webgl%2F2.0.0%2Fconformance%2Ftextures%2Fwebgl_canvas%2Ftex-2d-rgb-rgb-unsigned_short_5_6_5.html&test=webgl%2F2.0.0%2Fconformance%2Funiforms%2Fout-of-bounds-uniform-array-access.html&version_name=Monterey&flavor=wk2&architecture=x86_64

Diff:
There was a time out but the system was unable to capture a log correctly.

webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html
Link to diff: webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html
Comment 1 Radar WebKit Bug Importer 2022-04-15 08:55:40 PDT 
<rdar://problem/91810019>
Comment 2 Karl Rackler 2022-04-15 09:05:30 PDT 
I have marked this test as flaky time out while this issue is investigated.

Canonical link: https://commits.webkit.org/249679@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292909
Comment 4 Karl Rackler 2022-04-15 17:20:13 PDT 
I have marked these additional test as flaky timeout while this issue is investigated.

webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r8-red-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas/tex-2d-r8ui-red_integer-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas/tex-2d-r8-red-unsigned_byte.html
webgl/2.0.0/conformance/uniforms/uniform-default-values.html
webgl/2.0.0/conformance/textures/webgl_canvas/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html
webgl/2.0.0/conformance/textures/webgl_canvas/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html
webgl/2.0.0/conformance/textures/webgl_canvas/tex-2d-rgba-rgba-unsigned_byte.html
webgl/2.0.0/conformance/textures/misc/tex-image-and-sub-image-2d-with-array-buffer-view.html

Canonical link: https://commits.webkit.org/249697@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292932
Comment 5 Philippe Normand 2022-04-16 02:32:28 PDT 
Hi Karl,

How do you commit your patches? I noticed the commit message is indented, unlike the rest of the other contributors patches, example:

commit 0eb6fae27e0e769b9c3430e539b46a7f607e1135
Author: Karl Rackler <rackler@apple.com>
Date:   Sat Apr 16 00:18:32 2022 +0000

            [ Monterey wk2 ] WebGL conformance tests are a flaky time out
            Adding additional tests
            https://bugs.webkit.org/show_bug.cgi?id=239388
    
            Unreviewed test gardening.
    
            * platform/mac-wk2/TestExpectations:
    
    Canonical link: https://commits.webkit.org/249697@main
    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Comment 6 Karl Rackler 2022-04-18 07:30:02 PDT 
Hi Phillipe,

Thank you for the comment.  I discovered it was something on my side that I will get corrected.

Regards,
Karl
Comment 7 Ben Schwartz 2024-06-07 10:25:51 PDT 
This no longer appears to be occurring in its original form. Removing test expectations. Please file a new bug if issues persist.

Tracking test expectations removal in bug #274990 (rdar://129080660).