| Summary: | [git-webkit] Make the default rebase behavior for `git-webkit pr` configurable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, rego, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=250888 | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
|
Description
Antoine Quint
2022-04-15 07:47:54 PDT
Pull request: https://github.com/WebKit/WebKit/pull/295 I agree, rebases are very time consuming, and I believe by default it shouldn't do a rebase. That's what webkit-patch has been doing for years. Can we change the default in addition to making it configurable? Committed r295470 (251475@main): <https://commits.webkit.org/251475@main> Reviewed commits have been landed. Closing PR #295 and removing active labels. (In reply to Manuel Rego Casasnovas from comment #3) > I agree, rebases are very time consuming, and I believe by default it > shouldn't do a rebase. That's what webkit-patch has been doing for years. > > Can we change the default in addition to making it configurable? This change means contributors will be prompted in `git-webkit setup` for their personal default. Rebases were already configurable on a command-by-command basis (with --no-rebase and --rebase). Making this default to "No" during `git webkit setup` in bug 250888. |