| Summary: | Use the ProcessTerminationReason enum for all the process types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | WebKit Process Model | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, ap, cdumez, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2022-04-14 20:15:02 PDT
Created attachment 457670 [details]
Patch
Comment on attachment 457670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457670&action=review > Source/WebKit/Shared/ProcessTerminationReason.cpp:55 > + ASSERT_NOT_REACHED() ? > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:429 > + RELEASE_LOG_ERROR(Process, "%p - GPUProcessProxy::gpuProcessExited: reason=%s", this, processTerminationReasonToString(reason)); Needs to be %{public}s or we won't see the reason on production builds. > Source/WebKit/UIProcess/WebProcessPool.cpp:476 > + WEBPROCESSPOOL_RELEASE_LOG(Process, "gpuProcessDidExit: PID=%d, reason=%s", identifier, processTerminationReasonToString(reason)); Needs to be %{public}s or we won't see the reason on production builds. Comment on attachment 457670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457670&action=review > Source/WebKit/Shared/ProcessTerminationReason.cpp:56 > + return ""; "Invalid"? |