Bug 239351

Summary: Undo option after invoking "Markup Image" says "Undo Paste"
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, darin, esprehn+autocc, ews-watchlist, hi, kangil.han, katherine_cheney, megan_gardner, mifenton, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
For landing ews-feeder: commit-queue-

Description Wenson Hsieh 2022-04-14 12:48:07 PDT 
rdar://91647863
Comment 1 Wenson Hsieh 2022-04-14 13:03:30 PDT 
Created attachment 457644 [details]
Patch
Comment 2 Darin Adler 2022-04-14 15:22:46 PDT 
Comment on attachment 457644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review

> Source/WebCore/editing/EditAction.h:97
> +    Outdent,
> +    MarkupImage,

Looks like this was alphabetical before. Maybe keep it alphabetical?
Comment 3 Wenson Hsieh 2022-04-14 15:28:36 PDT 
Comment on attachment 457644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review

Thanks for the review!

>> Source/WebCore/editing/EditAction.h:97
>> +    MarkupImage,
> 
> Looks like this was alphabetical before. Maybe keep it alphabetical?

Will do!
Comment 4 Wenson Hsieh 2022-04-14 15:32:31 PDT 
Comment on attachment 457644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review

>>> Source/WebCore/editing/EditAction.h:97
>>> +    MarkupImage,
>> 
>> Looks like this was alphabetical before. Maybe keep it alphabetical?
> 
> Will do!

…since these enums are already unsorted, I'll go ahead and just put them all in sorted order while I'm here.
Comment 5 Darin Adler 2022-04-14 16:05:05 PDT 
Ah, only the part that showed up as context in diff was alphabetical! I should have suspected.
Comment 6 Wenson Hsieh 2022-04-14 16:08:45 PDT 
Created attachment 457654 [details]
For landing
Comment 7 EWS 2022-04-14 18:47:07 PDT 
Committed r292898 (249668@main): <https://commits.webkit.org/249668@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457654 [details].