| Summary: | [Xcode] Fix public watchOS workspace build by updating scheme and build settings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> | ||||||
| Component: | New Bugs | Assignee: | Elliott Williams <emw> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, ews-watchlist, hi, pangle, repstein, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Elliott Williams
2022-04-13 13:56:34 PDT
Created attachment 457567 [details]
Patch
Comment on attachment 457567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457567&action=review > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:-51 > - <BuildActionEntry Not clear to me what these changes are doing, and the patch lacks a ChangeLog. Created attachment 457568 [details]
Patch
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 457567 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457567&action=review > > > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:-51 > > - <BuildActionEntry > > Not clear to me what these changes are doing, and the patch lacks a > ChangeLog. Bad patch, sorry about that. Let me know if there's anything else I can clarify wrt the scheme changes. Comment on attachment 457568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457568&action=review > ChangeLog:19 > + - Remove MiniBrowser from the "All Source" scheme, as it's part of "All > + Tools". "All Tools" probably shouldn't be built for embedded This seems controversial. Engineers use MiniBrowser for testing during iteration, so there should be a one-step way to build WebKit and MiniBrowser at once. (In reply to Alexey Proskuryakov from comment #6) > Comment on attachment 457568 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457568&action=review > > > ChangeLog:19 > > + - Remove MiniBrowser from the "All Source" scheme, as it's part of "All > > + Tools". "All Tools" probably shouldn't be built for embedded > > This seems controversial. Engineers use MiniBrowser for testing during > iteration, so there should be a one-step way to build WebKit and MiniBrowser > at once. The way you'd do that is by building the MiniBrowser scheme, which will build the stack up to MiniBrowser, including WebKit. And if an engineer wanted to build the entire repo (like EWS does), they'd build "All Modules", which is intended to be equivalent to running `make` from the top-level directory. Committed r292845 (249618@main): <https://commits.webkit.org/249618@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457568 [details]. |