Bug 239279

Summary: [CSS Container Queries] Correct container selection for pseudo-elements
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229659    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Antti Koivisto 2022-04-13 02:03:37 PDT
The element itself may be the container for its pseudo-elements.
Comment 1 Antti Koivisto 2022-04-13 02:16:02 PDT
Created attachment 457518 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-04-13 10:42:59 PDT
Comment on attachment 457518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457518&action=review

> Source/WebCore/style/ContainerQueryEvaluator.h:42
> +    enum class SelectionMode { Element, PseudoElement };

: unit8_t
Comment 3 Darin Adler 2022-04-13 10:59:34 PDT
Comment on attachment 457518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457518&action=review

>> Source/WebCore/style/ContainerQueryEvaluator.h:42
>> +    enum class SelectionMode { Element, PseudoElement };
> 
> : unit8_t

or:

   : bool
Comment 4 Antti Koivisto 2022-04-13 11:03:26 PDT
Created attachment 457546 [details]
Patch for landing
Comment 5 EWS 2022-04-13 12:13:59 PDT
Committed r292819 (249599@main): <https://commits.webkit.org/249599@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457546 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-13 12:15:16 PDT
<rdar://problem/91707034>