| Summary: | Add logging for persistent notification event handler failure | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | beidson, cdumez, nham, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2022-04-12 09:56:32 PDT
Created attachment 457347 [details]
Patch
Comment on attachment 457347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457347&action=review > Source/WebCore/workers/service/server/SWServer.cpp:1376 > + RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed"); Shouldn't that be !succeeded ? (In reply to Chris Dumez from comment #2) > Comment on attachment 457347 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457347&action=review > > > Source/WebCore/workers/service/server/SWServer.cpp:1376 > > + RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed"); > > Shouldn't that be !succeeded ? Indeed, fixed! Created attachment 457632 [details]
Patch
Committed r292872 (249643@main): <https://commits.webkit.org/249643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457632 [details]. |