| Summary: | Complement implementation of step 5.5 of https://fetch.spec.whatwg.org/#http-fetch | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, darin, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2022-04-12 05:51:33 PDT
Created attachment 457328 [details]
Patch
Comment on attachment 457328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457328&action=review > Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:56 > + return ResourceError { errorDomainWebKitInternal, 0, response.url(), "Response served by service worker is cors while mode is same origin"_s, ResourceError::Type::AccessControl, ResourceError::IsSanitized::Yes }; Should error message say "CORS" instead of "cors"? Created attachment 457514 [details]
Patch for landing
(In reply to Darin Adler from comment #2) > Comment on attachment 457328 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457328&action=review > > > Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:56 > > + return ResourceError { errorDomainWebKitInternal, 0, response.url(), "Response served by service worker is cors while mode is same origin"_s, ResourceError::Type::AccessControl, ResourceError::IsSanitized::Yes }; > > Should error message say "CORS" instead of "cors"? Right, I updated the error message Committed r292804 (249586@main): <https://commits.webkit.org/249586@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457514 [details]. |