Bug 239118

Summary: [CSS Container Queries] Limit query range syntax
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229659    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Antti Koivisto
Reported 2022-04-12 01:54:19 PDT
The spec disallows things like (100px == width == 50px) and (100px < width > 10px).
Attachments
Patch (7.08 KB, patch)
2022-04-12 02:41 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (7.11 KB, patch)
2022-04-12 02:46 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (7.35 KB, patch)
2022-04-13 01:55 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-04-12 02:41:10 PDT
Created attachment 457319 [details] Patch
Antti Koivisto
Comment 2 2022-04-12 02:46:48 PDT
Created attachment 457322 [details] Patch
Darin Adler
Comment 3 2022-04-12 13:07:08 PDT
Comment on attachment 457322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457322&action=review > Source/WebCore/css/ContainerQueryParser.cpp:82 > + if (!sizeFeature || !blockRange.atEnd()) Why do we need the blockRange.atEnd() check, but no conditionRange.atEnd() check?
Antti Koivisto
Comment 4 2022-04-12 21:35:40 PDT
> Why do we need the blockRange.atEnd() check, but no conditionRange.atEnd() > check? consumeCondition always loops the range to the end, or returns a nullopt. consumeSizeFeature consumes the feature and returns a value whether at the end or not. Maybe it would be better to check in consumeSizeFeature itself.
Antti Koivisto
Comment 5 2022-04-13 01:55:22 PDT
Created attachment 457516 [details] Patch
EWS
Comment 6 2022-04-13 11:49:32 PDT
Committed r292816 (249596@main): <https://commits.webkit.org/249596@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457516 [details].
Radar WebKit Bug Importer
Comment 7 2022-04-13 11:50:17 PDT
<rdar://problem/91705554>
Note You need to log in before you can comment on or make changes to this bug.