| Summary: | [CSS Container Queries] Limit query range syntax | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 229659 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antti Koivisto
2022-04-12 01:54:19 PDT
Created attachment 457319 [details]
Patch
Created attachment 457322 [details]
Patch
Comment on attachment 457322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457322&action=review > Source/WebCore/css/ContainerQueryParser.cpp:82 > + if (!sizeFeature || !blockRange.atEnd()) Why do we need the blockRange.atEnd() check, but no conditionRange.atEnd() check? > Why do we need the blockRange.atEnd() check, but no conditionRange.atEnd()
> check?
consumeCondition always loops the range to the end, or returns a nullopt. consumeSizeFeature consumes the feature and returns a value whether at the end or not.
Maybe it would be better to check in consumeSizeFeature itself.
Created attachment 457516 [details]
Patch
Committed r292816 (249596@main): <https://commits.webkit.org/249596@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457516 [details]. |