| Summary: | Fix PlayStation build after r292696 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | Platform | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2022-04-11 17:44:11 PDT
Created attachment 457304 [details]
[fast-cq] Patch
Committed r292753 (249537@main): <https://commits.webkit.org/249537@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457304 [details]. Comment on attachment 457304 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457304&action=review > Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:48 > + capabilities.platformName = String::fromLatin1("playstation"); The preferred idiom here would be: capabilities.platformName = "playstation"_s; Unless that doesn’t compile for some reason? Comment on attachment 457304 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457304&action=review >> Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:48 >> + capabilities.platformName = String::fromLatin1("playstation"); > > The preferred idiom here would be: > > capabilities.platformName = "playstation"_s; > > Unless that doesn’t compile for some reason? Agreed, that's a clear use case for ASCIILiteral / ""_s. |