| Summary: | Add PlayStation builds to bot watcher's dashboard. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aakash_jain, darin, jbedard, ryanhaddad, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=239501 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ross Kirsling
2022-04-11 15:28:55 PDT
Created attachment 457294 [details]
Patch
Comment on attachment 457294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457294&action=review > Tools/CISupport/.gitignore:-8 > -public_html/ I think Aakash put this in quite deliberately because we end up with a bunch of logs in this directory on build.webkit.org. (In reply to Jonathan Bedard from comment #2) > Comment on attachment 457294 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457294&action=review > > > Tools/CISupport/.gitignore:-8 > > -public_html/ > > I think Aakash put this in quite deliberately because we end up with a bunch > of logs in this directory on build.webkit.org. Okay, but it means that we can't add new files to the directory, so we'd need to replace it with something more specific. Comment on attachment 457294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457294&action=review >>> Tools/CISupport/.gitignore:-8 >>> -public_html/ >> >> I think Aakash put this in quite deliberately because we end up with a bunch of logs in this directory on build.webkit.org. > > Okay, but it means that we can't add new files to the directory, so we'd need to replace it with something more specific. Are you sure that’s what it means? I’m pretty sure it just means git won’t complain when there are stray files; should not prevent doing a "git add" and committing the files. No, I mean it's not me performing cleanup; I was physically unable to create this patch without it:
> λ git add Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png
> The following paths are ignored by one of your .gitignore files:
> Tools/CISupport/build-webkit-org/public_html
> hint: Use -f if you really want to add them.
> hint: Turn this message off by running
> hint: "git config advice.addIgnoredFile false"
(In reply to Ross Kirsling from comment #5) > No, I mean it's not me performing cleanup; I was physically unable to create > this patch without it: > > > λ git add Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png > > The following paths are ignored by one of your .gitignore files: > > Tools/CISupport/build-webkit-org/public_html > > hint: Use -f if you really want to add them. > > hint: Turn this message off by running > > hint: "git config advice.addIgnoredFile false" Er, I guess that "hint" does work, so for the sake of this patch I can drop that change, but we definitely shouldn't being gitignoring committed files...the workaround here seems more like a bug than a feature to me. :-/ Created attachment 457483 [details]
Patch
(In reply to Ross Kirsling from comment #6) > (In reply to Ross Kirsling from comment #5) > > No, I mean it's not me performing cleanup; I was physically unable to create > > this patch without it: > > > > > λ git add Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png > > > The following paths are ignored by one of your .gitignore files: > > > Tools/CISupport/build-webkit-org/public_html > > > hint: Use -f if you really want to add them. > > > hint: Turn this message off by running > > > hint: "git config advice.addIgnoredFile false" > > Er, I guess that "hint" does work, so for the sake of this patch I can drop > that change, but we definitely shouldn't being gitignoring committed > files...the workaround here seems more like a bug than a feature to me. :-/ We should make a more narrow ignore, yeah, need to take a look on one of these bots to see exactly which files we're interested in ignoring. Tools/Scripts/svn-apply failed to apply attachment 457483 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 457564 [details]
Patch for landing
Created attachment 457565 [details]
Patch for landing
Tools/Scripts/svn-apply failed to apply attachment 457565 [details] to trunk.
Please resolve the conflicts and upload a new patch.
So yeah, this patch cannot be landed without fixing the .gitignore then. (In reply to Ross Kirsling from comment #13) > So yeah, this patch cannot be landed without fixing the .gitignore then. ...landed via CQ, I should say. Going to try landing this via GitHub. Committed r292843 (249616@main): <https://commits.webkit.org/249616@main> Reviewed commits have been landed. Closing PR #284 and removing active labels. |