| Summary: | [IFC][Integration] LayoutIntegration::LineLayout should not expose InlineContent | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-04-10 21:16:28 PDT
Created attachment 457230 [details]
Patch
Comment on attachment 457230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457230&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:497 > + return m_inlineContent ? m_inlineContent->hasVisualOverflow() : false; I like writing these with &&, would you consider that? (In reply to Darin Adler from comment #2) > Comment on attachment 457230 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457230&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:497 > > + return m_inlineContent ? m_inlineContent->hasVisualOverflow() : false; > > I like writing these with &&, would you consider that? good point! yes! Created attachment 457295 [details]
Patch
Committed r292752 (249536@main): <https://commits.webkit.org/249536@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457295 [details]. |