Bug 239050

Summary: [WebGPU] Implement correct ownership for WGPUQueues
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, djg, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 239043    
Attachments:
Description Flags
Patch kkinnunen: review+

Description Myles C. Maxfield 2022-04-10 11:12:34 PDT 
.
Comment 1 Myles C. Maxfield 2022-04-10 11:34:59 PDT 
Created attachment 457205 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-04-11 01:15:35 PDT 
Comment on attachment 457205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457205&action=review

> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-1964
> -				DD20DE6027BC90D80093D175 /* Gunzip.h in Headers */,

I wonder what this reordering is about..

> Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceHolderImpl.h:37
> +class ConvertToBackingContext;

redundant forward declare?
Comment 3 Myles C. Maxfield 2022-04-11 16:27:46 PDT 
Comment on attachment 457205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457205&action=review

>> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-1964
>> -				DD20DE6027BC90D80093D175 /* Gunzip.h in Headers */,
> 
> I wonder what this reordering is about..

I'll land this part separately.

>> Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceHolderImpl.h:37
>> +class ConvertToBackingContext;
> 
> redundant forward declare?

Good catch.
Comment 4 Myles C. Maxfield 2022-04-11 16:28:29 PDT 
Committed r292735 (249520@trunk): <https://commits.webkit.org/249520@trunk>
Comment 5 Radar WebKit Bug Importer 2022-04-11 16:29:15 PDT 
<rdar://problem/91595566>
Comment 6 Myles C. Maxfield 2022-04-11 16:29:22 PDT 
Comment on attachment 457205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457205&action=review

>>> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-1964
>>> -				DD20DE6027BC90D80093D175 /* Gunzip.h in Headers */,
>> 
>> I wonder what this reordering is about..
> 
> I'll land this part separately.

https://trac.webkit.org/changeset/292735/webkit
Comment 7 Myles C. Maxfield 2022-04-11 17:07:26 PDT 
Committed r292742 (249526@trunk): <https://commits.webkit.org/249526@trunk>