Bug 239030

Summary: Fails to build with error: use of undeclared identifier 'LC_MESSAGES'
Product: WebKit Reporter: Khem Raj <raj.khem>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, mcatanzaro, samuel_white
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Description Khem Raj 2022-04-09 07:48:13 PDT
when building with clang14 webkit 2.36 is failing to build and following error message is seen

TOPDIR/build/tmp/work/core2-32-yoe-linux/webkitgtk/2.36.0-r0/webkitgtk-2.36.0/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:115:51: error: use of undeclared identifier 'LC_MESSAGES'
            return g_variant_new_string(setlocale(LC_MESSAGES, nullptr));
                                                  ^
1 error generated.

We need to include locale.h for getting LC_MESSAGES definition
Comment 1 Khem Raj 2022-04-09 08:14:47 PDT
Created attachment 457164 [details]
proposed fix
Comment 2 EWS 2022-04-09 19:15:20 PDT
Committed r292684 (249476@main): <https://commits.webkit.org/249476@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457164 [details].