Bug 239029

Summary: Line clamp specific line-count code should be in RenderDeprecatedFlexibleBox
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

alan
Reported 2022-04-09 06:54:17 PDT
ssia
Attachments
Patch (2.93 KB, patch)
2022-04-09 06:58 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2022-04-09 07:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.82 KB, patch)
2022-04-09 09:23 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.76 KB, patch)
2022-04-09 21:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.29 KB, patch)
2022-04-10 06:59 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-04-09 06:58:27 PDT
Created attachment 457162 [details] Patch
alan
Comment 2 2022-04-09 07:08:40 PDT
Created attachment 457163 [details] Patch
alan
Comment 3 2022-04-09 09:23:21 PDT
Created attachment 457167 [details] Patch
alan
Comment 4 2022-04-09 21:15:08 PDT
Created attachment 457187 [details] Patch
alan
Comment 5 2022-04-10 06:59:41 PDT
Created attachment 457199 [details] Patch
EWS
Comment 6 2022-04-10 14:57:30 PDT
Committed r292689 (249481@main): <https://commits.webkit.org/249481@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457199 [details].
Radar WebKit Bug Importer
Comment 7 2022-04-10 14:58:16 PDT
<rdar://problem/91539294>
Darin Adler
Comment 8 2022-04-11 10:17:23 PDT
Comment on attachment 457199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457199&action=review > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:1035 > + maxLineCount = std::max<int>(maxLineCount, lineCountFor(downcast<RenderBlockFlow>(*child))); Chopping the size_t down to int; what makes that safe? Should the function check for overflow and return an int? > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:1050 > + int lineCount = lineCountFor(blockChild); Ditto.
alan
Comment 9 2022-04-15 09:19:06 PDT
(In reply to Darin Adler from comment #8) > Comment on attachment 457199 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457199&action=review > > > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:1035 > > + maxLineCount = std::max<int>(maxLineCount, lineCountFor(downcast<RenderBlockFlow>(*child))); > > Chopping the size_t down to int; what makes that safe? Should the function > check for overflow and return an int? > > > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:1050 > > + int lineCount = lineCountFor(blockChild); > > Ditto. bug 239389
Note You need to log in before you can comment on or make changes to this bug.