Bug 239026

Summary: [JSC] Reduce use of unnecessary cryptographicallyRandom numbers
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch saam: review+, ews-feeder: commit-queue-

Description Yusuke Suzuki 2022-04-08 23:45:30 PDT
[JSC] Use WeakRandom for MarkedBlock Freelist scramble
Comment 1 Yusuke Suzuki 2022-04-08 23:53:03 PDT
Created attachment 457156 [details]
Patch
Comment 2 Yusuke Suzuki 2022-04-09 00:51:07 PDT
Created attachment 457158 [details]
Patch
Comment 3 Yusuke Suzuki 2022-04-10 19:40:37 PDT
Created attachment 457225 [details]
Patch
Comment 4 Saam Barati 2022-04-11 09:20:20 PDT
Comment on attachment 457225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457225&action=review

r=me

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.cpp:37
> +    // No strong cryptographic characteristics is necessary.

is => are
Comment 5 Yusuke Suzuki 2022-04-11 13:04:12 PDT
Comment on attachment 457225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457225&action=review

>> Source/JavaScriptCore/assembler/AbstractMacroAssembler.cpp:37
>> +    // No strong cryptographic characteristics is necessary.
> 
> is => are

Done.
Comment 6 Yusuke Suzuki 2022-04-11 13:10:57 PDT
Committed r292714 (249504@trunk): <https://commits.webkit.org/249504@trunk>
Comment 7 Radar WebKit Bug Importer 2022-04-11 13:11:17 PDT
<rdar://problem/91584856>