Bug 239016

Summary: [GTK][WPE] Missing inter-module documentation links
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, cgarcia, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, pnormand, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226662
Bug Depends on:    
Bug Blocks: 242900    
Attachments:
Description Flags
Patch
none
Patch v2 none

Description Adrian Perez 2022-04-08 13:55:25 PDT 
After the switch to gi-docgen in #226662 the generated documentation
no longer has functioning links to other modules. We would want to
have references to e.g. GObject or GTK functions and types with usable
links :)
Comment 1 Adrian Perez 2022-04-08 14:07:08 PDT 
Created attachment 457116 [details]
Patch
Comment 2 Adrian Perez 2022-04-08 14:27:43 PDT 
Comment on attachment 457116 [details]
Patch

I found a small issue with the patch myself. I'll reupload a fixed v2.

View in context: https://bugs.webkit.org/attachment.cgi?id=457116&action=review

> Source/WebKit/gtk/urlmap.js.in:12
> +  ["JavaScriptCore", "../javascriptcoregtk-" + baseURLApiLevelSuffix],

The trailing dash here is not needed, because there is a dash already as
the first character of the “baseURLApiLevelSuffix” variable.
Comment 3 Adrian Perez 2022-04-08 14:28:26 PDT 
Created attachment 457117 [details]
Patch v2
Comment 4 EWS 2022-04-09 01:36:16 PDT 
Committed r292678 (249470@main): <https://commits.webkit.org/249470@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457117 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-09 01:37:16 PDT 
<rdar://problem/91518259>