| Summary: | [WPE][2.36] Build with a11y disabled fails | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | WPE WebKit | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 457076 [details]
Patch
Comment on attachment 457076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457076&action=review > Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:50 > XDGDBusProxy::XDGDBusProxy(Type type, bool allowPortals) > : m_type(type) > { > +#if ENABLE(ACCESSIBILITY) > switch (m_type) { > case Type::SessionBus: > m_dbusAddress = g_getenv("DBUS_SESSION_BUS_ADDRESS"); I think you're removing too much here, right? This will break the non-a11y proxy too? Created attachment 457084 [details]
Patch
Committed r292628 (249448@main): <https://commits.webkit.org/249448@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457084 [details]. |
../Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:52:67: error: no member named 'accessibilityBusAddress' in 'WebCore::PlatformDisplay' m_dbusAddress = WebCore::PlatformDisplay::sharedDisplay().accessibilityBusAddress().utf8(); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated.