Bug 238978

Summary: Fix accessibility/aria-invalid.html in isolated tree mode
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tyler Wilcock 2022-04-07 20:17:48 PDT 
Fix accessibility/aria-invalid.html in isolated tree mode
Comment 1 Radar WebKit Bug Importer 2022-04-07 20:17:58 PDT 
<rdar://problem/91460480>
Comment 2 Tyler Wilcock 2022-04-07 20:24:26 PDT 
Created attachment 457007 [details]
Patch
Comment 3 Tyler Wilcock 2022-04-07 23:10:05 PDT 
Created attachment 457024 [details]
Patch
Comment 4 Andres Gonzalez 2022-04-08 05:16:26 PDT 
(In reply to Tyler Wilcock from comment #3)
> Created attachment 457024 [details]
> Patch

--- a/LayoutTests/resources/accessibility-helper.js
+++ a/LayoutTests/resources/accessibility-helper.js

+    const evalExpression = `${expression} === ${expectedValue}`;
+    if (eval(evalExpression))
+        return `PASS: ${evalExpression}\n`;
+    else
+        return `FAIL: ${expression} !== ${expectedValue}\n`;

Can we write this more succinctly as

+    if (eval(`${expression} === ${expectedValue}`))
+        return `PASS: ${evalExpression}\n`;
+    return `FAIL: ${expression} !== ${expectedValue}\n`;
Comment 5 Tyler Wilcock 2022-04-08 11:54:29 PDT 
Created attachment 457106 [details]
Patch
Comment 6 EWS 2022-04-10 00:30:20 PDT 
Committed r292686 (249478@main): <https://commits.webkit.org/249478@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457106 [details].