Bug 238960

Summary:	REGRESSION(r292306): [ iOS ] fast/attachment/attachment-disabled-rendering.html is a text missing failure
Product:	WebKit	Reporter:	Dawn Morningstar <Morningstar>
Component:	New Bugs	Assignee:	Tim Nguyen (:ntim) <ntim>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ntim, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=238739

Description Dawn Morningstar 2022-04-07 14:38:39 PDT

fast/attachment/attachment-disabled-rendering.html
Is a 'Missing text' failure on iOS EWS.

The issue does not appear in the results database and is interesting because it has an "Image", DIFF, and STDERR.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fattachment%2Fattachment-disabled-rendering.html

The first build I've seen this on EWS is:
https://ews-build.webkit.org/#/builders/68/builds/12367

DIFF:
--- /Volumes/Data/worker/iOS-15-Simulator-WK2-Tests-EWS/build/layout-test-results/fast/attachment/attachment-disabled-rendering-expected.txt
+++ /Volumes/Data/worker/iOS-15-Simulator-WK2-Tests-EWS/build/layout-test-results/fast/attachment/attachment-disabled-rendering-actual.txt
@@ -1,11 +1,11 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x50
-  RenderBlock {HTML} at (0,0) size 800x50
-    RenderBody {BODY} at (8,16) size 784x18
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 766x18
+layer at (0,0) size 800x52
+  RenderBlock {HTML} at (0,0) size 800x52
+    RenderBody {BODY} at (8,16) size 784x20
+      RenderBlock {P} at (0,0) size 784x20
+        RenderText {#text} at (0,0) size 766x19
           text run at (0,0) width 766: "This tests that attachments don't have a custom renderer when they are disabled. This test must be run in the test runner."
-      RenderBlock (anonymous) at (0,34) size 784x0
+      RenderBlock (anonymous) at (0,36) size 784x0
         RenderInline {ATTACHMENT} at (0,0) size 0x0
         RenderText {#text} at (0,0) size 0x0

DIFF-URL:
https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/456594-12367-clean-tree/results.html

"IMAGE":
NoSuchKeyThe specified key does not exist.iOS-15-Simulator-WK2-Tests-EWS/456594-12367-clean-tree/fast/attachment/attachment-disabled-rendering-diffs.htmlTGA7P06VZGZM4PT63hpUYckpcgfvMMXBeMMCDeOtGZoHv1oUXrf1qiRACKKA2umiik53X2q2/VDYr9Md+4ET3jm58vg=

IMAGE-URL:
https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/456594-12367-clean-tree/fast/attachment/attachment-disabled-rendering-diffs.html

STDERR:
2022-04-04 20:29:57.377 WebKitTestRunnerApp[59856:997434] Writing analzed variants.
2022-04-04 20:29:57.504 WebKitTestRunnerApp[59856:997434] Writing analzed variants.
objc[59856]: Class _PathPoint is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore (0x12a5d9a78) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/TextInputUI.framework/TextInputUI (0x13094e8b0). One of the two will be used. Which one is undefined.
objc[59856]: Class _PointQueue is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore (0x12a5d9a50) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/TextInputUI.framework/TextInputUI (0x13094e8d8). One of the two will be used. Which one is undefined.

Comment 1 Radar WebKit Bug Importer 2022-04-07 14:39:25 PDT

<rdar://problem/91444780>

Comment 2 Dawn Morningstar 2022-04-07 14:46:53 PDT

Marking expectations to help EWS r292568

Comment 3 Dawn Morningstar 2022-04-20 20:48:59 PDT

It looks like Tim adjusted the test here: r292306 which is also the first time it started failing. Suspected regression point.

Comment 4 Dawn Morningstar 2022-04-20 20:49:42 PDT

Failure is not visible not only on iOS but also in history.

Comment 5 Dawn Morningstar 2022-04-20 20:49:58 PDT

(In reply to Matteo Flores from comment #4)
> Failure is not visible not only on iOS but also in history.

Now visible*

Comment 6 Tim Nguyen (:ntim) 2022-04-21 00:57:41 PDT

Rebaselining the iOS result should be fine in this case.

Comment 7 Tim Nguyen (:ntim) 2022-04-21 03:53:17 PDT

Committed r293162 (249847@trunk): <https://commits.webkit.org/249847@trunk>