Bug 238945

Summary: [IDL] Make JSGenerateToJSObject the default behavior
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: ASSIGNED ---    
Severity: Normal CC: alecflett, beidson, calvaris, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, hi, hta, jer.noble, joepeck, jsbell, kangil.han, kondapallykalyan, macpherson, menard, mifenton, pangle, pdr, philipj, sabouhallawa, schenney, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
ews-feeder: commit-queue-
WIP Patch
none
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
none
WIP Patch
none
WIP Patch
ews-feeder: commit-queue-
WIP Patch ews-feeder: commit-queue-

Description Chris Dumez 2022-04-07 10:48:36 PDT 
Make JSGenerateToJSObject the default behavior and always generate the toJS() function, even if the interface has a parent.
I verified locally that it doesn't increase the size of the WebCore binary.

Missing JSGenerateToJSObject the IDL can lead to hard to diagnose crashes / bugs when implementing new Web APIs.
Having a toJS() for the subclass is also better for performance than relying on the toJS() from a base class which has to do type checking.
Comment 1 Chris Dumez 2022-04-07 10:49:41 PDT 
Created attachment 456941 [details]
WIP Patch
Comment 2 Chris Dumez 2022-04-07 11:05:29 PDT 
Created attachment 456944 [details]
WIP Patch
Comment 3 Chris Dumez 2022-04-07 11:09:17 PDT 
Created attachment 456947 [details]
WIP Patch
Comment 4 Chris Dumez 2022-04-07 11:28:06 PDT 
Created attachment 456951 [details]
WIP Patch
Comment 5 Chris Dumez 2022-04-07 12:56:01 PDT 
Created attachment 456957 [details]
WIP Patch
Comment 6 Chris Dumez 2022-04-07 16:36:34 PDT 
Created attachment 456985 [details]
WIP Patch
Comment 7 Chris Dumez 2022-04-07 16:43:50 PDT 
Created attachment 456989 [details]
WIP Patch
Comment 8 Chris Dumez 2022-04-07 16:52:48 PDT 
Created attachment 456990 [details]
WIP Patch
Comment 9 Chris Dumez 2022-04-07 17:21:02 PDT 
Created attachment 456996 [details]
WIP Patch
Comment 10 Chris Dumez 2022-04-07 19:02:06 PDT 
Created attachment 457003 [details]
WIP Patch
Comment 11 Radar WebKit Bug Importer 2022-04-14 10:49:14 PDT 
<rdar://problem/91763968>