Bug 238945

Summary:

[IDL] Make JSGenerateToJSObject the default behavior

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

ASSIGNED

Severity:

Normal

CC:

alecflett, beidson, calvaris, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, hi, hta, jer.noble, joepeck, jsbell, kangil.han, kondapallykalyan, macpherson, menard, mifenton, pangle, pdr, philipj, sabouhallawa, schenney, sergio, tommyw, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
WIP Patch	none
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-

Chris Dumez

Reported 2022-04-07 10:48:36 PDT

Make JSGenerateToJSObject the default behavior and always generate the toJS() function, even if the interface has a parent. I verified locally that it doesn't increase the size of the WebCore binary. Missing JSGenerateToJSObject the IDL can lead to hard to diagnose crashes / bugs when implementing new Web APIs. Having a toJS() for the subclass is also better for performance than relying on the toJS() from a base class which has to do type checking.

Attachments
WIP Patch (1.04 KB, patch) 2022-04-07 10:49 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (32.45 KB, patch) 2022-04-07 11:05 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (32.59 KB, patch) 2022-04-07 11:09 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (32.63 KB, patch) 2022-04-07 11:28 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (46.65 KB, patch) 2022-04-07 12:56 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (50.26 KB, patch) 2022-04-07 16:36 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (51.61 KB, patch) 2022-04-07 16:43 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (51.87 KB, patch) 2022-04-07 16:52 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (64.65 KB, patch) 2022-04-07 17:21 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (68.97 KB, patch) 2022-04-07 19:02 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.