| Summary: | [JSC] Fix compile warnings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail R. Gadelha <mikhail> | ||||||
| Component: | New Bugs | Assignee: | Mikhail R. Gadelha <mikhail> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, glore, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mikhail R. Gadelha
2022-04-07 09:24:23 PDT
Created attachment 456937 [details]
Patch
r-, this is not OK. This function is *super* hot, and any kind of these addition can hurt performance. Use IGNORE_RETURN_TYPE_WARNINGS_BEGIN / IGNORE_RETURN_TYPE_WARNINGS_END instead. Are you sure it's that bad? These are only inserted after the switches... is it because they might be inlined? We can also use ASSERT_NOT_REACHED instead, WDYT? ASSERT_NOT_REACHED is `((void)0)` on the release build so you would probably still get the warnings. Created attachment 457843 [details]
Patch
Comment on attachment 457843 [details]
Patch
r=me
Already fixed on ToT. |