Bug 238941

Summary: [JSC] Fix compile warnings
Product: WebKit Reporter: Mikhail R. Gadelha <mikhail>
Component: New BugsAssignee: Mikhail R. Gadelha <mikhail>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glore, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ysuzuki: review+

Mikhail R. Gadelha
Reported 2022-04-07 09:24:23 PDT
[JSC] Fix compile warnings
Attachments
Patch (2.96 KB, patch)
2022-04-07 09:25 PDT, Mikhail R. Gadelha 		no flags
DetailsFormatted DiffDiff
Patch (3.85 KB, patch)
2022-04-18 17:16 PDT, Mikhail R. Gadelha 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail R. Gadelha
Comment 1 2022-04-07 09:25:24 PDT
Created attachment 456937 [details] Patch
Yusuke Suzuki
Comment 2 2022-04-08 11:22:04 PDT
r-, this is not OK. This function is *super* hot, and any kind of these addition can hurt performance. Use IGNORE_RETURN_TYPE_WARNINGS_BEGIN / IGNORE_RETURN_TYPE_WARNINGS_END instead.
Mikhail R. Gadelha
Comment 3 2022-04-08 11:27:57 PDT
Are you sure it's that bad? These are only inserted after the switches... is it because they might be inlined? We can also use ASSERT_NOT_REACHED instead, WDYT?
Geza Lore
Comment 4 2022-04-11 03:41:48 PDT
ASSERT_NOT_REACHED is `((void)0)` on the release build so you would probably still get the warnings.
Radar WebKit Bug Importer
Comment 5 2022-04-14 09:25:14 PDT
<rdar://problem/91757981>
Mikhail R. Gadelha
Comment 6 2022-04-18 17:16:09 PDT
Created attachment 457843 [details] Patch
Yusuke Suzuki
Comment 7 2022-04-18 17:22:50 PDT
Comment on attachment 457843 [details] Patch r=me
Mikhail R. Gadelha
Comment 8 2022-04-19 07:59:02 PDT
Already fixed on ToT.
Note You need to log in before you can comment on or make changes to this bug.