| Summary: | Move long-enabled preferences away from experimental | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||
| Component: | New Bugs | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||
| Severity: | Normal | CC: | bdakin, beidson, bfulgham, thorton, tsavell, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Sneddon [:gsnedders]
2022-04-07 06:24:47 PDT
Created attachment 456916 [details]
Patch
Created attachment 456930 [details]
Patch
Comment on attachment 456930 [details]
Patch
Very nice!
Comment on attachment 456930 [details]
Patch
Nice!
Committed r292586 (249419@main): <https://commits.webkit.org/249419@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456930 [details]. Reverted r292586 for reason: Caused 50+ test failures on Mac wk1 Committed r292642 (249462@trunk): <https://commits.webkit.org/249462@trunk> for context we began seeing g50+ failures on Mac wk1 from this change. This was causing ews runs to exit early for wk1. Build: https://build.webkit.org/#/builders/48/builds/9431 Results: https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r292634%20(9431)/results.html Example history: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Freferrer-policy-anchor%2Forigin-when-cross-origin%2Fcross-origin-http.https.html The trick here, I think, is that moving them from Experimental to normal means they no longer get implicitly enabled by DRT. Previously, ReferrerPolicyAttributeEnabled was disabled by default in WebKit1, but enabled in DRT (along with all other experimental features). Now it's disabled by default in WebKit1, period, and the tests fail. We've done a lot of work on tidying up preferences over the past year, so it seems like this can probably be safely closed? Oh yes! Thank you. |